Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch dependency from zendframework to laminas #36677

Merged
merged 1 commit into from
Jan 2, 2020
Merged

switch dependency from zendframework to laminas #36677

merged 1 commit into from
Jan 2, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 2, 2020 •
edited
Loading

Description

  1. Change from zendframework to laminas dependencies.
    See issue description.

I also updated the min versions to reflect what was actually being used from the previous zendframework repos, just to make sure that nothing goes backwards.

  1. Adjust ownCloud code that specifies Zend classes to use Laminas classes.
composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 6 updates, 0 removals
  - Installing laminas/laminas-zendframework-bridge (1.0.0): Downloading (100%)         
  - Updating laminas/laminas-stdlib (3.2.1 => 3.2.1): Downloading (100%)         
  - Updating laminas/laminas-validator (2.13.0 => 2.13.0): Downloading (100%)         
  - Updating laminas/laminas-servicemanager (3.4.0 => 3.4.0): Downloading (100%)         
  - Updating laminas/laminas-filter (2.9.2 => 2.9.2): Downloading (100%)         
  - Updating laminas/laminas-inputfilter (2.10.1 => 2.10.1): Downloading (100%)         
  - Updating roave/security-advisories (dev-master 44a677c => dev-master 5306962)
Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Writing lock file
Generating optimized autoload files

Note: https://discourse.zendframework.com/t/container-interop-container-interop-is-abandoned/1260/6 container-interop is a dependency in zendframework (now laminas ). laminas is planning to remove that in the next major release. So that "abandoned" message will be around for a while. Actually it is fine - the latest release of container-interop is fine.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis added 2 - Developing dependencies php Pull requests that update Php code labels Jan 2, 2020
@phil-davis phil-davis self-assigned this Jan 2, 2020
@phil-davis phil-davis force-pushed the zendframework-laminas branch from e7e8202 to a8bc4c5 Compare January 2, 2020 04:11
@codecov
Copy link

codecov bot commented Jan 2, 2020 •
edited
Loading

Codecov Report

Merging #36677 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36677   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19106    19106           
=========================================
  Files          1269     1269           
  Lines         74728    74728           
  Branches       1320     1320           
=========================================
  Hits          48337    48337           
  Misses        26003    26003           
  Partials        388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (ø) 19106 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...b/private/Share/Filters/MailNotificationFilter.php 100% <ø> (ø) 8 <0> (ø) ⬇️
core/Command/User/ResetPassword.php 70.52% <ø> (ø) 23 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb722a...1f278e9. Read the comment docs.

@phil-davis phil-davis force-pushed the zendframework-laminas branch from a8bc4c5 to 1f278e9 Compare January 2, 2020 16:02
@micbar micbar merged commit 74986e2 into master Jan 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the zendframework-laminas branch January 2, 2020 19:28
@davitol davitol mentioned this pull request Jan 9, 2020
Closed
39 tasks
This was referenced Feb 26, 2020
Merged
Closed
@phil-davis phil-davis mentioned this pull request Jun 30, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@phil-davis phil-davis

Labels
3 - To Review dependencies php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zendframework changing to laminas
2 participants
@phil-davis @micbar